-
Couldn't load subscription status.
- Fork 7
findMany method's where
#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
intaniger
wants to merge
10
commits into
softnetics:main
Choose a base branch
from
intaniger:intaniger/find-many-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cdd64f The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2330a86 to
202f7fc
Compare
dd8672c to
aa95733
Compare
30fe73f to
e14108e
Compare
e14108e to
44bca04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
wherecondition tofindManymethodSee filter.spec.ts for usage.
See the transformQueryObjectToSQL test for reference.
/admin/collections/custom-food-pagepage to demonstrate how to use thewherecondition.name,isCooked, andcookingTypefields that will change the page's query once submitted to filter out data. See Display component for reference.Tip
Add a custom list component to demonstrate how to display data with custom cell rendering.
see renderFoodsCells for reference.
Screen.Recording.2568-06-28.at.18.52.43.mov
And why I did it
Why not?
Just kidding;
Because currently the server doesn't have filter functionality. The only way to do this is via client-side, which will be sophisticated and troublesome; i.e., filtering data that are limited to the first n records would give the user an incomplete result.
Nevertheless, providing a trivial filter, such as
likewould not be sufficient for real-world use cases. So it's better to give them all operators that drizzle provided. Along with type-safety capability, that would help developers from foot-gunning themselves by mistyping or unknowingly using the where filter in a misconceived way.And I believe that supporting nested query, i.e.,
{ "$or": [ { "$and": [ { "text": { "$like": "%A%" } }, { "$or": [ { "smallint": { "$inArray": [4, 3, 2, 1] } }, { "real": { "$gte": 30 } } ] } ] } ], "boolean": { "$eq": true } }is necessary for, possibly, complex filtering use cases.
The added
/admin/collections/custom-food-pageis intended to demonstrate how to use a filter in source code.